cadence-java-client icon indicating copy to clipboard operation
cadence-java-client copied to clipboard
verified publisher icon uber

Potential bugs -- Workflow.currentTimeMillis() shouldn't change during replay

Open longquanzheng opened this issue 3 years ago • 1 comments

See https://github.com/uber/cadence-java-client/blob/cb5d6ecaeb206044213d9ab2cf45bd74d6f8b654/src/main/java/com/uber/cadence/internal/replay/ClockDecisionContext.java#L185

During replay, the value passed in timer(by Workfllow.sleep() ) can impact Workflow.currentTimeMillis()` if the firing time value is later than current time.

This could cause issue for replay because the value is different from non-replay mode.

longquanzheng avatar Apr 13 '22 19:04 longquanzheng

Not sure is there any application is still relying on this.

Temporal Java SDK has removed this.

longquanzheng avatar Apr 13 '22 20:04 longquanzheng