cadence-java-client icon indicating copy to clipboard operation
cadence-java-client copied to clipboard

Activity metrics shows identical value

Open szaluzhskiy opened this issue 4 years ago • 1 comments

Hello team!

I've noticed that graphs of next metrics on Activity shows are almost same value in case of Activity attempt failure:

  • cadence-activity-execution-failed
  • cadence-activity-task-failed

I propose to rethink location of metrics in code, let them increment in another cases.

From my point of view metric cadence-activity-execution-failed should be incremented in case of activity failed after all attempts are failed. Metric cadence-activity-task-failed incremented if one attempt of activity execution, on every retry step, failed

szaluzhskiy avatar Oct 07 '20 07:10 szaluzhskiy

Good suggestion.

meiliang86 avatar Oct 09 '20 22:10 meiliang86