baseweb icon indicating copy to clipboard operation
baseweb copied to clipboard

fix(button): change secondary selected colors

Open maxshymchuk opened this issue 2 years ago • 6 comments

Fixes #3722

Description

The selected state for secondary button returns primary colors instead of secondary colors. Changes:

  • color: $theme.colors.buttonPrimaryText => color: $theme.colors.buttonSecondarySelectedText
  • backgroundColor: $theme.colors.buttonPrimaryFill => backgroundColor: $theme.colors.buttonSecondarySelectedFill

Scope

Patch: Bug Fix

maxshymchuk avatar Dec 08 '21 11:12 maxshymchuk

@maxshymchuk is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 08 '21 11:12 vercel[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 08 '21 11:12 CLAassistant

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c5c81a42e79ec0c7c1691db599eeafb8c6c4da25:

Sandbox Source
Basic usage Configuration

codesandbox-ci[bot] avatar Dec 08 '21 11:12 codesandbox-ci[bot]

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/maxshymchuk/baseweb/pull/1

UberOpenSourceBot avatar Dec 15 '21 20:12 UberOpenSourceBot

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/2LMUbaqPTn94fTXvf59T1KzbsjL5
✅ Preview: https://baseweb-git-fork-maxshymchuk-master-uber-ui-platform.vercel.app

vercel[bot] avatar Dec 16 '21 22:12 vercel[bot]

Thank you for submitting this PR. Since opening, we've updated the source code to typescript. Can you please update the code change?

chasestarr avatar Aug 16 '22 20:08 chasestarr

Thank you for submitting this PR. We will not be changing these colors

chasestarr avatar Oct 04 '22 17:10 chasestarr