Global overrides flow fixes
Fixes #106
Description
This branch is based on the PRs #4149 and #4260 . Have tried to fix all flow errors resulting from the global overrides feature addition.
- Components have been fixed using Config to type the default props
- any instead of mixed has been used in combobox because flow throws error with the type declaration for mapOptionToString. Setting as ReadOnly does not work, so any was used.
- Components with generic types in props have any used as well in declaring the config. mixed doesnt work with generic types either.
- some intersection types have been converted to exact spreads ba on documentation provided here. exact object spread
Scope
Minor: New Feature
@vasdhara is attempting to deploy a commit to the Uber UI Platform Team on Vercel.
A member of the Team first needs to authorize it.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit ecfef7055d9b0569dc84670ef9d3efd1c54a0ab8:
| Sandbox | Source |
|---|---|
| Basic usage | Configuration |
@tajo does this approach seem viable to you?
@tajo (maybe also @chasestarr) we discussed this in #106 as a viable approach for setting properties like input border width without having to add new theme properties -- it'd be really great to get this in and as you can see it touches a lot of stuff so the merge conflict list keeps growing and growing. Can you help us understand if this makes sense to you and what else we might need to do to get it in? Thanks!!
Hi, this feature is not something we plan on investing time into. I'll go ahead and close the PR to make that clear. Thank you all for exploring the potential.