baseweb icon indicating copy to clipboard operation
baseweb copied to clipboard

Setting isLoading on a Button that is in Chrome running Google Translate crashes unless the contents are wrapped in a span

Open leyanlo opened this issue 3 years ago • 0 comments

Setting isLoading on a Button that is in Chrome running Google Translate crashes unless the contents are wrapped in a span:

Button: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Button crash 2021-07-21 17_57_29

See codesandbox: https://codesandbox.io/s/base-web-button-forked-lowxh?file=/src/example.js Running app: https://lowxh.csb.app/

This is sort of an issue with how React works with Google Translate: https://github.com/facebook/react/issues/11538 https://bugs.chromium.org/p/chromium/issues/detail?id=872770

We have been seeing crashes in our customers’ logs. In practice, we are fixing these by wrapping all our Button contents with span, but we were hoping we could get Base Web to fix the component in such a way that we don’t need this workaround. Thanks!

leyanlo avatar Jul 22 '21 01:07 leyanlo