UberSignature icon indicating copy to clipboard operation
UberSignature copied to clipboard

Passing an image to initializer does nothing

Open marchinram opened this issue 6 years ago • 2 comments

https://github.com/uber/UberSignature/blob/master/Sources/Swift/SignatureDrawingViewController.swift#L40

public init(image: UIImage? = nil) {
        super.init(nibName: nil, bundle: nil)
    }

The passed image is not used or shown in view controller when using this initializer, I would expect that when I pass an image to this initializer it would show the image

marchinram avatar Feb 22 '19 01:02 marchinram

As objective-c code change the init method to:

public init(image: UIImage? = nil) {
        super.init(nibName: nil, bundle: nil)
        presetImage = image
    }

arashetm avatar Apr 16 '19 10:04 arashetm

When can you merge this fix to the master?

AntonioFerreira94 avatar Aug 30 '19 17:08 AntonioFerreira94