RemoteShuffleService icon indicating copy to clipboard operation
RemoteShuffleService copied to clipboard

Remove use of String format in favor of SLF4J anchor

Open belugabehr opened this issue 4 years ago • 1 comments

There is no need to use String#format with SLF4J as SLF4J supports its own formatting mechanism called an "anchor."

http://www.slf4j.org/faq.html#logging_performance

Remove a bunch of instances of this practice for clarity and it actually hurts performance for debug level logging as SLF4J is able to perform that anchor-substitution lazily, only if debug mode is enabled.

belugabehr avatar Jul 22 '21 01:07 belugabehr

Note: I didn't hit every instance, just some of the easier ones and don't want to commit to doing them all without some hope that this will be accepted. :)

belugabehr avatar Jul 22 '21 01:07 belugabehr