NullAway icon indicating copy to clipboard operation
NullAway copied to clipboard

[WIP] Fix issue with serialization in running multiple modules in parallel.

Open nimakarimipour opened this issue 3 years ago • 1 comments

This PR fixes #626 which explains how current implementation by using a fixed files name for outputs, limits parallelization techniques in environments where multiple execution units are available.

To address this issue, this PR enables NullAway to choose a UUID at the time of initialization, and will use that unique id as a prefix for all serialized outputs. This way, any instance of NullAway will work on a separate set of files and will not encounter any race issues.

File name changes:

  • errors.tsv -> UUID-errors.tsv
  • fixes.tsv -> UUID-fixes.tsv
  • field_init.tsv -> UUID-field_init.tsv

nimakarimipour avatar Jul 27 '22 23:07 nimakarimipour

@lazaroclapp let's not review this PR yet, as I may have found a better solution for this which does not require this change in NullAway.

nimakarimipour avatar Jul 28 '22 06:07 nimakarimipour

@nimakarimipour can we close this one?

msridhar avatar Aug 23 '22 21:08 msridhar

@msridhar Sure, our recent experiments shows the other approach works and this PR is not needed.

nimakarimipour avatar Aug 23 '22 21:08 nimakarimipour