NullAway icon indicating copy to clipboard operation
NullAway copied to clipboard

Task2

Open haewiful opened this issue 1 year ago • 1 comments

Thank you for contributing to NullAway!

Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.

Before pressing the "Create Pull Request" button, please provide the following:

  • [ ] Added support for generic identity functions with explicitly-typed nullness.

  • [ ] Related to the issue #1035.

  • [ ] void genericNonNullIdentityFunction() and void genericNullAllowingIdentityFunction() unit tests are added to GenericMethodTests.java file.

haewiful avatar Oct 08 '24 06:10 haewiful

Codecov Report

Attention: Patch coverage is 93.24324% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (238363a) to head (641b9ee). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ava/com/uber/nullaway/generics/GenericsChecks.java 93.05% 0 Missing and 5 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1053      +/-   ##
============================================
+ Coverage     87.60%   87.65%   +0.05%     
- Complexity     2204     2222      +18     
============================================
  Files            85       85              
  Lines          7195     7269      +74     
  Branches       1416     1436      +20     
============================================
+ Hits           6303     6372      +69     
  Misses          456      456              
- Partials        436      441       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 14 '24 20:10 codecov[bot]

This support is incomplete (even for cases with explicit type arguments), but let's go ahead and land it and do things in pieces. Thanks!

msridhar avatar Oct 30 '24 23:10 msridhar