ocular icon indicating copy to clipboard operation
ocular copied to clipboard

Publish beta didn't properly update dependencies in luma.gl

Open tsherif opened this issue 6 years ago • 3 comments

The incorrect dependencies were manually fixed in this commit: https://github.com/uber/luma.gl/commit/27f1654eb9f505063a36396897952968cf5cfddd

I was publishing a new alpha version of luma.gl and went through the following steps:

  1. Set version in lerna.json to 7.1.0-alpha.0
  2. Run npm run publish beta

My understanding is that this should publish version 7.1.0-alpha.1 and update all internal dependencies accordingly. It did so correctly in most places, but a few of the dependencies were incorrectly set to 7.1.0-alpha.0.

tsherif avatar May 13 '19 19:05 tsherif

Maybe those packages didn't change. See https://github.com/lerna/lerna/blob/master/commands/version/README.md#--force-publish

ibgreen avatar May 13 '19 20:05 ibgreen

Don't we already force publish all modules? It seems to be inconsistent about which dependencies get updated and which don't, e.g. before my fix: https://github.com/uber/luma.gl/blob/241483c0fac705b7ff9f6e4819097a3628fd4ea7/modules/debug/package.json

version is 7.1.0-alpha.1, and dependency on @luma.gl/constants is 7.1.0-alpha.1, but peer dependency on @luma.gl/core is 7.1.0-alpha.0.

tsherif avatar May 13 '19 20:05 tsherif

Actually looking at it now, it looks like it's just the caret (^) versions that aren't updated, which kind of makes sense. But why does it change them to alpha.0 and then not update them further? And what would be the right approach to avoid this?

tsherif avatar May 13 '19 20:05 tsherif