zap

zap copied to clipboard

Using zapcore.Level less than -1 and sampling causes a panic

3

When someone sets the `zapcore.Level(-2)` with sampling set to true, there is a panic. ``` github.com/presslabs/mysql-operator/vendor/go.uber.org/zap/zapcore.(*counters).get(0xc0001d2000, 0xc000151cfe, 0xbb762a, 0xc, 0xc000151be0) /home/x/go/src/github.com/presslabs/mysql-operator/vendor/go.uber.org/zap/zapcore/sampler.go:48 +0x79 github.com/presslabs/mysql-operator/vendor/go.uber.org/zap/zapcore.(*sampler).Check(0xc00018f560, 0xfe, 0xbee5907d06b7cfd4, 0x2a36d55, 0x11b62a0, 0xbb4baf, 0x7, 0xbb762a,...

shawn-hurley

I'm looking at various different loggers, and I like the idea of implementing something performant out of gate, but the documentation included is not very friendly for new users. Here...

ghostsquad

Add a boolean field to log entry that would indicate potential sampling

5

Now, this could be a controversial one, because of the added ambiguity. There is no way to indicate that an entry has been sampled because of the very definition of...

pavel-shpilev

Implement gokit/log's Logger interface in the SugaredLogger

1

I'd like to extend the [`SugaredLogger`](https://godoc.org/go.uber.org/zap#SugaredLogger) to implement [go-kit/log](https://github.com/go-kit/kit/tree/master/log)'s [`log.Logger`](https://godoc.org/github.com/go-kit/kit/log#Logger) interface. This would make `zap` easier to integrate with codebases that already use [`go-kit/log`](https://github.com/go-kit/kit/tree/master/log) and simplify migrating to `zap` down...

alex-laties

Add an option to override stacktrace collection logic

5

# Stacktrace collection While trying to implement an encoder that is compatible with GCP Stackdriver logging and also for GCP Stackdriver Error Reporting, I suspected that it's not working properly...

zllak

WrapEncoder Option

3

I'm adding Prometheus metrics for logging and I would like to be able to track the encoded length of entries. For example: ``` # HELP log_entries_total Total number of log...

abursavich

Add support for RFC3339Nano as another zapcore.TimeEncoder

1

zapcore package has implemented 4 types of TimeEncoder (Epoch, EpochMillis, EpochNanos, and ISO8601). Is it possible to add RFC3339 and RFC3339Nano or any other standard format in go's time package....

nattawitc

I'm really confused that we are serializing the message and only then checking to see if we need it at all. I must be dull, I cannot imagine a case...

NathanZook

Causer not implemented

1

Hi, in the [zap-core error](https://github.com/uber-go/zap/blob/master/zapcore/error.go) docs, you say: > // Finally, if the error implements errorGroup (from go.uber.org/multierr) or > // causer (from github.com/pkg/errors), a ${key}Causes field is added with...

DAddYE

Unable to install with Dep

3

https://github.com/uber-go/zap/issues/451 This exact same issue, still.

natdm