zap icon indicating copy to clipboard operation
zap copied to clipboard

Published 20 hours ago • verified publisher icon uber-go

[Feature] zapgrpc.Logger implements Experimental DepthLoggerV2

Open forsaken628 opened this issue 2 years ago • 4 comments

https://github.com/uber-go/zap/issues/1267

https://github.com/grpc/grpc-go/blob/5e587344eef8aaa06ebf76ee1997013b3a8fbed0/grpclog/loggerv2.go#L240

and fix verbosity https://github.com/grpc-ecosystem/go-grpc-middleware/pull/452

forsaken628 avatar Apr 05 '23 08:04 forsaken628

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 05 '23 08:04 CLAassistant

@forsaken628 thanks for the submission, do you have any additional info on why this is needed on Zap's side? The issue you created doesn't have most of its fields filled out properly.

sywhang avatar May 05 '23 20:05 sywhang

The current zapgrpc package is poorly maintained and outdated. This PR just fills in the parts that this package should have. Or zapgrpc should be marked as deprecated.

forsaken628 avatar May 09 '23 12:05 forsaken628

Any updates on this? It definitely looks like zapgrpc package is outdated compared to grpc-go-middleware past version, the grpclog verbosity level variable GRPC_GO_LOG_VERBOSITY_LEVEL currently does not seem to be working at all.

frbvianna avatar Mar 07 '24 13:03 frbvianna