nilaway

nilaway copied to clipboard

Fix convergence problem due to unbounded growing of assertion tree

2

This PR fixes the convergence issues causes by unbounded growing of assertion trees with assignments in a loop, such as in the simple example shown below. ``` func test() {...

sonalmahajan15

Fix for nested non-builtin call expression in map access

2

This PR refines the logic of non-literal map access, particularly in the case of built-in call expressions, to not consider the index trackable if there exists a nested call to...

sonalmahajan15

Refactor the contract analyzer

2

This PR simply refactors the contract analyzer to prepare for further updates. Specifically, it (1) Defines a separate type for `[]Contract` such that it can be made to be exported...

yuxincs

Implement fact export for manually-written and inferred function contracts

2

This PR implements the fact export for manually-written and inferred function contracts. Specifically it enhances the `functioncontracts` sub-analyzer, which imports contracts from upstream packages, parses/infers the contracts for the local...

yuxincs

Add w/o grouping run in golden test

3

This PR updates the golden test in CI to run under two modes: with and without grouping of similar errors.

sonalmahajan15

False positive on unassigned variable guarded by `switch`

1

NilAway reports a false positive error for the switch case as shown below. The switch case ``` func test() { var x interface{} switch v := x.(type) { case nil:...

sonalmahajan15

false positive from strings.Split

3

[`strings.Split`](https://pkg.go.dev/strings#Split) is guaranteed to return a non-nil slice with at least one element, so alerting from calling that is a false positive. ``` /Users/adam/code/src/github.com/moov-io/base/telemetry/attributes.go:84:19: error: Potential nil panic detected. Observed...

adamdecaf

Internal panic (conflicting position information on upstream object) with latest rules_go

5

After updating to the latest rules_go and version of nilaway I am now getting the following panic: ``` /create.go:1:1: error: INTERNAL PANIC: conflicting position information on upstream object go.mongodb.org/mongo-driver/mongo.Cursor.M7: existing:...

kpaulisse

False positive in error handling logic for "always-safe" case

6

NilAway is encoded with the pattern that if the error return is non-nil, then inherently assume non-error returns to be nilable, and hence need guarding. However, this reports a false...

sonalmahajan15

NilAway can support prevalently found short-circuiting in non-conditional logical expressions. Examples of supported expressions are shown below (refer to [nonconditional.go](https://github.com/uber-go/nilaway/blob/main/testdata/src/go.uber.org/nilcheck/nonconditionalflow.go) for detailed test cases). ``` return x != nil &&...

sonalmahajan15