mock icon indicating copy to clipboard operation
mock copied to clipboard

`nil` value `TestReporter` in `NewController`

Open cyrusv opened this issue 2 years ago • 1 comments

Is this allowed or not? It does not throw an error right away, but opens the door for NPEs in methods like (h *nopTestHelper) Errorf(. I understand it might be backwards incompat to start enforcing now, so it is a constraint we can relax, or at least document?

cyrusv avatar Sep 29 '23 17:09 cyrusv

I believe that we should support a nil input but rework the logic of the nopTestHelper to have an actual nop implementation instead of something that would panic.

r-hang avatar Oct 03 '23 18:10 r-hang