cadence-client icon indicating copy to clipboard operation
cadence-client copied to clipboard

[cadence/debug] Update polletracker to support poller type breakdown

Open ketsiambaku opened this issue 11 months ago • 1 comments

What changed? We use the PollerTracker interface to count the number of running pollers and we display it internal in a debug page. This change is updating the interface and its usage so that the poller count is broken down by worker type (e.g: activity, workflow, shadow, localactivity, etc.)

Why? The break down gives a better insight on the running instance

How did you test it? unit tests

Potential risks

ketsiambaku avatar Dec 02 '24 09:12 ketsiambaku

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.52%. Comparing base (e3802b7) to head (65fdc1b). Report is 1 commits behind head on master.

Files with missing lines Coverage Δ
internal/common/debug/workerstats_noop.go 100.00% <100.00%> (ø)
internal/internal_worker_base.go 83.41% <100.00%> (+1.46%) :arrow_up:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3802b7...65fdc1b. Read the comment docs.

codecov[bot] avatar Dec 05 '24 00:12 codecov[bot]