cadence-client icon indicating copy to clipboard operation
cadence-client copied to clipboard

downgrade thrift to backend compatible version

Open 3vilhamster opened this issue 1 year ago • 2 comments

What changed? I downgraded apache/thrfit version to the version compatible on the Cadence backend.

Why? Cadence backend uses client to run internal operations, so client should be compatible with the backend.

How did you test it? unit tests/integration tests

Potential risks Potential failures for customers using up to date thrift version.

3vilhamster avatar Dec 19 '23 15:12 3vilhamster

Hmm 🤔 I get how this is a problem with our old pinned version internally but... why hasn't it been a problem all along? Seems like this probably changed at #1189 so it has been in place for quite a while / we have definitely upgraded past that internally.

Groxx avatar Mar 04 '24 21:03 Groxx

hmm in the monorepo the version is set to 0.17.0 and it client works. Let me try 0.17.0 then, might be it will be fine.

3vilhamster avatar Mar 06 '24 18:03 3vilhamster