hyperbahn icon indicating copy to clipboard operation
hyperbahn copied to clipboard

Log `willSample` prepublish replacer

Open rf opened this issue 9 years ago • 4 comments

This requires an updated larch so it isn't ready to land yet, but it works.

Wrote a simple script to insert willSample checks before log lines. I messed around with using some macro systems (sweet.js and the C preprocessor) but found that neither would work. The replacer script is an inelegant solution but it's short and it works.

r: @raynos @jcorbin

rf avatar Jan 08 '16 20:01 rf

This seems reasonable.

I want to try running it and looking at a diff of the pre-process vs post-process.

Also we need to figure out what to do in terms of workflow, prepublish might have to copy into a "build/*" folder and we should change the package.json to import from there.

Then we can .gitignore build/*

Raynos avatar Jan 08 '16 22:01 Raynos

tests fail lal.

Raynos avatar Jan 09 '16 00:01 Raynos

Changed this to use publish.sh. It's real ugly but it runs the replacer, makes a temp commit, creates the package, then resets git.

rf avatar Jan 09 '16 02:01 rf

we need to fix debug logtron.

Raynos avatar Jan 11 '16 23:01 Raynos