hacheck icon indicating copy to clipboard operation
hacheck copied to clipboard

Supports the backend port being sent in the HAProxy send-state header

Open jolynch opened this issue 9 years ago • 9 comments

When service ports are assigned dynamically, haproxy sends the port in the send-state header rather than in the healthcheck uri because there is no way to make the uri contain the dynamically generated port. This adds support for deducing the port number from that header if it is present.

This is only useful if running HAProxy with the following commit, which is not yet merged into a 1.5 release branch (although Willy said that he planned to pull it in): http://git.haproxy.org/?p=haproxy.git;a=commitdiff;h=514061c414080701cb046171041a2d00859660e8

Also adds support for periods in service names.

jolynch avatar Apr 10 '15 21:04 jolynch

Can you rebase this on master so it can get the new tests I added?

Roguelazer avatar Apr 21 '15 19:04 Roguelazer

Rebased on master but my run of the tests indicates it's ok (waiting on travis CI)

..............

Ran 60 tests in 1.227s

OK

jolynch avatar Apr 21 '15 20:04 jolynch

it looks like travis is sort of broken (their status page says they're "degraded"). I'll check back on this in a couple of hours and hope that travis has fixed their issues.

Roguelazer avatar Apr 21 '15 20:04 Roguelazer

Heh, that's a lot of tornado versions.

jolynch avatar Apr 21 '15 23:04 jolynch

@Roguelazer, it looks like Travis is less broken now. Is there anything else I should do for this to be ready for merge?

jolynch avatar Apr 28 '15 17:04 jolynch

@Roguelazer gentle ping?

jolynch avatar May 08 '15 08:05 jolynch

Looks like Willy is cutting HAProxy 1.6-dev2 soon which is the feature freeze that included the needed change for this branch to be needed. Is there anything else I should do to make this ready for merge?

jolynch avatar Jun 03 '15 02:06 jolynch

+1 for getting this merged.

jnb avatar Jun 11 '15 06:06 jnb

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 27 '19 13:06 CLAassistant