coldfront icon indicating copy to clipboard operation
coldfront copied to clipboard

Allocation Change Request: "Add new attribute"

Open mdzik opened this issue 3 years ago • 2 comments

Some attributes are unique, others are not (for example IP addresses specified as attributes by PI in license allocations). I would make sens to allow not only change but to request new attribute added.

I was thinking, to extend change request to allow that if:

  • attribute is changeable
  • attribute in not unique
  • allocation already have at least one of that type
  • maybe also add some flag, per analogy to 'is_changeable'?

This will require slight change in the model to accommodate data for non-existing attribute before approval. Is this ok your cases?

mdzik avatar May 27 '22 11:05 mdzik

@mdzik Yes, this all sounds good to me. @dsajdak do you have issues/suggestions to the above changes with respect to our workflow?

aebruno avatar May 30 '22 18:05 aebruno

I think it would be useful to allow PIs to request a new attribute on an allocation change request. I agree with all the suggestions except I'm not sure it's necessary to require that an allocation already has one of that type. I just might not be envisioning how others use change requests though. Are you thinking this would prevent a user from asking for a new attribute that doesn't match up with that particular resource type the allocation goes with?

dsajdak avatar May 31 '22 12:05 dsajdak