vue-country-flag icon indicating copy to clipboard operation
vue-country-flag copied to clipboard

Published 20 hours ago • verified publisher icon ubaldop

Andorra missing its 2-character country code

Open VizualAbstract opened this issue 5 years ago • 2 comments
trafficstars

It looks like in the recent update (thank you so much!) Andorra was missing its 2-digit country code.

This PR aims to restore that: https://github.com/P3trur0/vue-country-flag/pull/33

Screen Shot 2020-05-29 at 3 14 41 PM

VizualAbstract avatar May 29 '20 22:05 VizualAbstract

Hi @VizualAbstract thanks for proposing this change. Actually because of #27 I had to do a workaround for Andorra flag.
As you may notice here you can still use ad when declaring the flag, but on component side it is translated to f-andorra CSS class.

ubaldop avatar May 31 '20 20:05 ubaldop

However I leave your proposal still opened here because instead of restoring "f-ad" it could be better of get rid of "f-andorra" CSS class leaving only "f-and" instead.
So, referring to this, it could become:

country = (country === 'ad') ? 'and' : country

would you mind to align your PR with this improvement?

Doing so could make the component slightly lighter.

ubaldop avatar May 31 '20 20:05 ubaldop