mtuq icon indicating copy to clipboard operation
mtuq copied to clipboard

New header **kwargs patch for plot_data_greens3

Open thurinj opened this issue 2 months ago • 5 comments

This should solve issue #332 - fairly minimal fix.

I am not a huge fan of the resulting header when using 3 different filtering parameters: image (the time window duration is clipped out of the figure).

I can merge the PR as is in the next day or two if you want (so @ammcpherson can move forward with her work), or take a bit more time to rework the overall text arrangement so everything fits tightly in frame of the figure. (We can probably have the layout a bit smarter depending on what we have to insert in the figure's header.) Let me know what's the best for you.

tag: @rmodrak, @ammcpherson

thurinj avatar Oct 23 '25 13:10 thurinj

I am fine waiting a bit for you to tighten things up. My workaround currently works fine for this particular project

ammcpherson avatar Oct 24 '25 15:10 ammcpherson

Hi @ammcpherson,

Could you please test this one out, I think it should do the trick! (It should shrink down the overflowing line). Thanks for waiting for the update!

thurinj avatar Oct 27 '25 07:10 thurinj

Not sure why the build isn't working with this one, I have not added any dependencies. Might be 'okay' since this branch misfit function is still dated from before all @rmodrak recent changes (numba based misfit evaluation)

thurinj avatar Oct 27 '25 08:10 thurinj

@thurinj So this branch would not have the new misfit function? That is more vital to this particular project of mine than the header/waveform plotting issue

ammcpherson avatar Oct 31 '25 15:10 ammcpherson

Hi @ammcpherson, the branch doesn't have it, but the PR only brings the changes in the header.py file (see the list of modified files in the PR GitHub recap).

thurinj avatar Nov 01 '25 02:11 thurinj