dvm-dos-tem icon indicating copy to clipboard operation
dvm-dos-tem copied to clipboard

Simplify `ParentLayer.cpp` and `SnowLayer.cpp`

Open dogukanteber opened this issue 9 months ago • 1 comments

Layer class has the following virtual methods:

virtual double getFrzThermCond()=0; // get frozen layer thermal conductivity
virtual double getUnfThermCond()=0; // get unfrozen layer thermal conductivity
virtual double getFrzVolHeatCapa()=0;// get frozen layer specific heat capcity
virtual double getUnfVolHeatCapa()=0;// get unfrozen layer specific heat capacity
virtual double getMixVolHeatCapa()=0;//Yuan

The implementation of some of these methods are same in ParentLayer.cpp and SnowLayer.cpp. We cannot merge the same methods in a single method. So, this PR attempts to explain why these methods have the same implementation. It also cleans up the method implementation.

dogukanteber avatar May 14 '24 18:05 dogukanteber