uap-ruby icon indicating copy to clipboard operation
uap-ruby copied to clipboard

Support for addtional custom databases

Open pkubat opened this issue 12 years ago • 2 comments

The ability to support more that one regexes database file. (regexes should be any array of filenames)

The thought here is that one file would be the "standard" from https://github.com/tobie/ua-parser/blob/master/regexes.yaml and another might contain "custom" user agents. They could be appended to the standard by sections; user_agent_parsers, os_parsers, ,device_parsers.

The files should be "loaded" in order.

Also see the request for Logstash: https://logstash.jira.com/browse/LOGSTASH-1323

pkubat avatar Sep 20 '13 15:09 pkubat

Sure, sounds reasonable!

Perhaps the :patterns_path option could take an array, and Parser#load_patterns can be refactored to take an array of paths, rather than just a single path: https://github.com/toolmantim/user_agent_parser/blob/master/lib/user_agent_parser/parser.rb

Pull request welcome!

toolmantim avatar Sep 23 '13 12:09 toolmantim

@pkubat I realize this has been a while. Do you think you'll be able to do a PR with the requested functionality?

wallin avatar Jun 13 '17 19:06 wallin