uap-java icon indicating copy to clipboard operation
uap-java copied to clipboard

UserAgent Parser does not support patchMinor

Open lukezhang2000 opened this issue 2 years ago • 0 comments

patchMinor is not included in the UserAgent Parser. For Chrome browsers, the parser will not catch the full name of the UserAgent, i.e. (https://github.com/ua-parser/uap-core/blob/09e9ccca9fcfc4348ae9e89815135bafcd0676bb/tests/test_ua.yaml#L2579-L2584) For 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36', the patchMinor would be "78", but that would not be captured by our parser.

Is the exclusion of patchMinor intentional for the UserAgent browser, or should that be added into the UserAgent class?

I believe there is an ongoing PR that's been out for this: https://github.com/ua-parser/uap-java/pull/61

lukezhang2000 avatar Aug 22 '22 22:08 lukezhang2000