uap-go issues

fix(sort): add better sorting options to avoid too much but have more control.

2

… at beginning.

aryehlev

Benchmarks

8

In #26, it shows that each op takes ~26ms. Is that still accurate?

derekperkins

Optimize for top-user-agents

2

Teaches the build script to clone top UAs and optimize the matching order accordingly. This leads to huge speedups in real-world (browser) usage.

dzbarsky

Add cache to drastically improve performance

The caching is a bit janky and atypical of a parsing library, but I think the performance improvements justify it. ``` benchmark old ns/op new ns/op delta BenchmarkParser-32 13418192 38386...

ammario

Stop using MustCompile, and instead return an error if any regex fails to compile

4

The use of regex.MustCompile (see: https://github.com/ua-parser/uap-go/blob/daf92ba38329329419decc8e322bcd9480964294/uaparser/parser.go#L354-L360 ) means that if any regex fails, there is a panic. We pull down the master regex url daily, so that our regexes are...

veqryn

32 Bit systems

2

Go does not provide automatic alignment for the 32 bit system In sync/atomic/asm_386.s we see that the 64 bit operations have the following preamble: ``` MOVL addr+0(FP), BP TESTL $7,...

0x4139

Incorrect UserAgent.Minor

I have the following user-agent: Mozilla/5.0 (iPhone; CPU iPhone OS 11_4 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Coast/5.04.110603 Mobile/15F79 Safari/7534.48.3 BrowserMinorVersion (UserAgent.Minor) is parsed incorrectly, it is parsed...

t-vorobyova

Regexes sorting is incorrect

7

According to [specification](https://github.com/ua-parser/uap-core/blob/master/docs/specification.md#user_agent_parsers): > The list of regular-expressions regex shall be evaluated for a given user-agent string beginning with the first regex-item in the list to the last item. The...

gkalabin