uap-csharp icon indicating copy to clipboard operation
uap-csharp copied to clipboard

Extract nested classes to separate files

Open FroggieFrog opened this issue 2 years ago • 1 comments

This idea for this PR is based on #60, but it just extracts all nested classes to their own files (CTRL + . and "Move to xx.cs"). this is common best pratice in the .NET world. Also all files were formatted via Edit->Advanced->Format Document.

Hopefully it makes it easier to add the performance improvements from #60 and future ones.

FroggieFrog avatar Oct 25 '21 09:10 FroggieFrog

Finally had a look at this. Beyond the move to separate files, I think you also moved some classes into other namespaces (Implementations, Abstractions, Extensions)? I am personally not a fan of such a separation but more critical is that it'll break backwards compatibility if we move existing classes to new namespaces. I would prefer a fully flat namespace.

enemaerke avatar Nov 12 '21 22:11 enemaerke