URL in code comment points to unrelated website

Open remnantkevin opened this issue 1 year ago • 1 comments

I was reading through regexes.yaml to learn a bit more about the structure of iOS/macOS user agent strings, and visited the following link (L1385) about CFNetwork versions. However, this link took me to what seems to be a website related to prostitution. I wanted to flag this so that it could hopefully be removed or updated to a relevant website about CFNetwork versions.

https://github.com/ua-parser/uap-core/blob/cd5291016e6764b509776ad4206cff1c8b035280/regexes.yaml#L1383-L1385

May 08 '24 05:05 remnantkevin

Looks like the owner let the domain lapse in 2019~2020 and (as is often the case) some scammy / scummy individual took it over: https://web.archive.org/web/20190201000000*/http://user-agents.me

Options are to either:

link to the archived version of the page: https://web.archive.org/web/20160609194154/https://user-agents.me/cfnetwork-version-list
just remove the link entirely
try to find a more authoritative or reliable source (also more up to date)

May 12 '24 13:05 masklinn