uap-core icon indicating copy to clipboard operation
uap-core copied to clipboard

Cannot detect device on new Chrome version for Android

Open rodrigoflores opened this issue 6 years ago • 0 comments

Hi,

Due to removal of the Build number on mobile version for Chrome (https://www.chromestatus.com/feature/4558585463832576), the device regexes started returning a generic device brand for a known device.

I've added a broken test on my branch https://github.com/rodrigoflores/uap-core/commit/f312b7a125e21147efce9cdefb858c588e79c454 it is returning Generic_Android instead of Motorola for the brand. I'm not sure which is the best way since the regexps rely a lot on the Build string.

Adding @caique-lima who found the source.

rodrigoflores avatar Nov 07 '18 23:11 rodrigoflores