uap-core icon indicating copy to clipboard operation
uap-core copied to clipboard

Windows family contains major version

Open theikkila opened this issue 7 years ago • 1 comments

Windows UA:s have been recognized with major version as part of the family.

ie.

Mozilla/5.0 (Windows NT 10.0## Win64## x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063
{ "family": "Windows 10",
   "major": null,
   "minor": null,
   "patch": null,
   "patchMinor": null },

should be:

{ "family": "Windows",
   "major": "10",
   "minor": null,
   "patch": null,
   "patchMinor": null }

or even with minor defined too

theikkila avatar Nov 29 '17 19:11 theikkila

I suspect this is addressed by https://github.com/ua-parser/uap-core/pull/110 and https://github.com/ua-parser/uap-core/pull/286

jimdigriz avatar Apr 06 '18 17:04 jimdigriz