nuPickers icon indicating copy to clipboard operation
nuPickers copied to clipboard

Fix for ListPicker icons being invisible

Open greystate opened this issue 6 years ago • 7 comments

Fixes #190

  • The color classes seem to have been renamed with a color- prefix (good thing) which is why the icons were invisible (white on white, as it were). Using color-red and color-blue fixes this.

  • Also, the generic .button class has was picked up by Umbraco which resulted in some spacing issues; renaming this to picker-button fixes this problem.

@Hendy Any verdict on the new class name? Should it be shorter? Something else?

Note: I have not used any of the other pickers in this solution, but I'm guessing there could be problems with some of the others too. So maybe we need to identify them and fix as well in this PR?

greystate avatar Sep 20 '18 20:09 greystate

@greystate How to get hold on an updated DLL with this fix included?

👍

thaggren avatar Oct 30 '18 15:10 thaggren

@greystate How to get hold on an updated DLL with this fix included?

I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)

If compiling your own is not an option, I guess I can make it available for you somehow...

greystate avatar Oct 30 '18 15:10 greystate

Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...

Hendy avatar Oct 30 '18 16:10 Hendy

@greystate How to get hold on an updated DLL with this fix included?

I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)

If compiling your own is not an option, I guess I can make it available for you somehow...

@greystate Added your fixes manually and compiled a new DLL ... seems to be working :)

thaggren avatar Oct 31 '18 14:10 thaggren

Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...

@Hendy Would be great with an official updated DLL :)

thaggren avatar Oct 31 '18 14:10 thaggren

In the meantime, if you want to apply a temporary fix using only CSS, I've posted something simple to implement here:

https://our.umbraco.com/packages/backoffice-extensions/nupickers/questionssuggestions/94833-fix-for-listpicker-icons-being-invisible-191

stevesuk avatar Dec 05 '18 12:12 stevesuk

@stevesuk great "hack/fix" - thanks :)

thaggren avatar Dec 11 '18 21:12 thaggren