nuPickers
nuPickers copied to clipboard
Fix for ListPicker icons being invisible
Fixes #190
-
The color classes seem to have been renamed with a
color-
prefix (good thing) which is why the icons were invisible (white on white, as it were). Usingcolor-red
andcolor-blue
fixes this. -
Also, the generic
.button
class has was picked up by Umbraco which resulted in some spacing issues; renaming this topicker-button
fixes this problem.
@Hendy Any verdict on the new class name? Should it be shorter? Something else?
Note: I have not used any of the other pickers in this solution, but I'm guessing there could be problems with some of the others too. So maybe we need to identify them and fix as well in this PR?
@greystate How to get hold on an updated DLL with this fix included?
👍
@greystate How to get hold on an updated DLL with this fix included?
I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)
If compiling your own is not an option, I guess I can make it available for you somehow...
Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...
@greystate How to get hold on an updated DLL with this fix included?
I built it myself with Visual Studio for the Mac (yes, I was surprised that it actually worked :-)
If compiling your own is not an option, I guess I can make it available for you somehow...
@greystate Added your fixes manually and compiled a new DLL ... seems to be working :)
Hi @greystate, thanks for this fix - I'll try it out and all being well release a 1.7.1...
@Hendy Would be great with an official updated DLL :)
In the meantime, if you want to apply a temporary fix using only CSS, I've posted something simple to implement here:
https://our.umbraco.com/packages/backoffice-extensions/nupickers/questionssuggestions/94833-fix-for-listpicker-icons-being-invisible-191
@stevesuk great "hack/fix" - thanks :)