react-vimeo icon indicating copy to clipboard operation
react-vimeo copied to clipboard

controls prop has no effect or is not well documented

Open gordonCharles opened this issue 2 years ago • 1 comments

The controls prop is documented as:

Name | Type | Default | Description

controls | bool | true | Hide all elements in the player (play bar, sharing buttons, etc).

Changes to the value of controls (true or false) has no effect on the objects I've highlighted on the attached image. Either the documentation is for something else and is not sufficiently clear or prop has no effect.

`import React from "react"; import Vimeo from "@u-wave/react-vimeo";

export default function App() {

return ( <div className="App"> <Vimeo video="245095318" showTitle={false} showPortrait={false} showByline={false} controls={true} playsInline={false} width={"500"} /> ); }`

react-vimeo_issue

gordonCharles avatar Aug 10 '22 22:08 gordonCharles

+1

jgalianoz avatar Aug 11 '22 20:08 jgalianoz

The controls prop maps directly to the controls option in the vimeo player SDK. https://github.com/vimeo/player.js#embed-options

This parameter will hide all elements in the player (play bar, sharing buttons, etc) for a chromeless experience. ⚠️Warning: When using this parameter, the play bar and UI will be hidden. To start playback for your viewers, you'll need to either enable autoplay or use our player SDK to start and control playback. (available to Plus, PRO, or Business members)

so if you're not a paying vimeo customer it won't work.

goto-bus-stop avatar Aug 23 '22 10:08 goto-bus-stop

The controls prop maps directly to the controls option in the vimeo player SDK. https://github.com/vimeo/player.js#embed-options

This parameter will hide all elements in the player (play bar, sharing buttons, etc) for a chromeless experience. ⚠️Warning: When using this parameter, the play bar and UI will be hidden. To start playback for your viewers, you'll need to either enable autoplay or use our player SDK to start and control playback. (available to Plus, PRO, or Business members)

so if you're not a paying vimeo customer it won't work.

Thank you for sharing. Agree with the OP, it would help if this was a part of the documentation.

vyas-meet avatar Sep 29 '22 08:09 vyas-meet