react-vimeo icon indicating copy to clipboard operation
react-vimeo copied to clipboard

Problems with onEnd, onPause, etc in strict mode

Open Feli02 opened this issue 2 years ago • 6 comments

When I use any "on" event is not working the event, when I use the onEnd event, when the video finished no event is fire, same with other events such as pause. Everything else works fine, but those events are not working.

Feli02 avatar May 19 '22 19:05 Feli02

same issue. Any updates?

zotovy avatar May 30 '22 10:05 zotovy

Ye, same issue here. If you found a workaround, please drop it here.

EDIT:

After some research found this:

https://github.com/cookpete/react-player/issues/1453#issuecomment-1126687518

Removing React.StrictMode solved the issue for me

Lexe003 avatar Jun 05 '22 15:06 Lexe003

After some research found this: https://github.com/cookpete/react-player/issues/1453#issuecomment-1126687518 Removing React.StrictMode solved the issue for me

🤯

i am not sure when i can have a deeper look at this. The fact that StrictMode changes the behaviour suggests that it's to do with React double-mounting in development mode? it would be important to be compatible with this.

goto-bus-stop avatar Jun 09 '22 18:06 goto-bus-stop

Any updates?

itsdenispavlovic avatar Dec 07 '22 14:12 itsdenispavlovic