react-vimeo icon indicating copy to clipboard operation
react-vimeo copied to clipboard

Published 20 hours ago • verified publisher icon u-wave

Use hooks, support React 18, drop React < 16

Open goto-bus-stop opened this issue 2 years ago • 6 comments

Similar to https://github.com/u-wave/react-youtube/pull/117.

This will be version 1.0 of the library.

It uses hooks internally instead of a class. The published code targets modern browsers but you can still transpile it if you need to.

There should be no API changes.

goto-bus-stop avatar May 01 '22 14:05 goto-bus-stop

When do we expect to merge this? And why is it necessary to drop React <= 16

joshuarcher avatar Jul 28 '22 05:07 joshuarcher

No real timeline on merging this, as it's not really that important for end users anyways. The feature set is the same as the class component version from 0.x.

I want to align this release with my other embed modules (especially @u-wave/react-youtube) and the hooks approach has some caveats wrt unmounting and the timing of destroying the player. As it's going to be 1.0, i want to be sure that there are no bugs around that :)

goto-bus-stop avatar Oct 17 '22 10:10 goto-bus-stop

Any updates on when this or the other PRs will be merged?

bnolan001 avatar Mar 04 '24 14:03 bnolan001

Not currently. are you looking for a particular improvement from this PR?

goto-bus-stop avatar Mar 04 '24 15:03 goto-bus-stop

Having a version number that is 1.0 makes the library an easier sell for usage in a project.

bnolan001 avatar Mar 05 '24 20:03 bnolan001

I'll aim to finish, test, and release this by the time React 19 comes out.

goto-bus-stop avatar Apr 26 '24 07:04 goto-bus-stop