react-vimeo icon indicating copy to clipboard operation
react-vimeo copied to clipboard

Warnings and errors

Open mgoldenbe opened this issue 4 years ago • 11 comments

When embedding a public Vimeo video (<Vimeo video="..." />), I get the following:

image

mgoldenbe avatar Oct 18 '21 20:10 mgoldenbe

The vimeo SDK might expect a hex colour without a # in front. Not totally sure, but that is the only format they list in their docs: https://developer.vimeo.com/player/sdk/embed

goto-bus-stop avatar Oct 19 '21 08:10 goto-bus-stop

Is there an attribute I can specify in my code to get rid of this error?

mgoldenbe avatar Oct 19 '21 12:10 mgoldenbe

i don't know what your code looks like :) are you specifying a color now?

it's hard to tell if the errors are even caused by react-vimeo, but if they are, the only thing i can think of based on those logs is that you're entering an invalid color prop. I assume the second error line is not caused by react-vimeo at all, that looks like an issue with video_toolbar.js.

goto-bus-stop avatar Oct 19 '21 12:10 goto-bus-stop

I quoted my vimeo-related code in the question:

<Vimeo video="..." />

This is it on my side and there are no errors without this line.

mgoldenbe avatar Oct 19 '21 14:10 mgoldenbe

…I haven't replied because I don't know :)

I never tried using it in an extension. Maybe this package doesn't work in extension scripts for some reason. If you/someone wants to dig into it and see what's going on…

goto-bus-stop avatar Nov 03 '21 09:11 goto-bus-stop

What do you mean by "an extension"? This is a React library and I used it in React, i.e. its primary use. Am I missing something?

mgoldenbe avatar Nov 03 '21 15:11 mgoldenbe

I assumed you were developing a browser extension because the stack trace has a chrome-extension:// url in it. runtime.lastError is also something to do with browser extensions.

goto-bus-stop avatar Nov 03 '21 16:11 goto-bus-stop

No, I am developing a website with React.js frontend and Django backend...

mgoldenbe avatar Nov 03 '21 17:11 mgoldenbe

Oh…does the embed work correctly?

goto-bus-stop avatar Nov 03 '21 17:11 goto-bus-stop

The video is embedded and plays, but I am not sure whether the warning and the errors can be safely ignored.

mgoldenbe avatar Nov 04 '21 06:11 mgoldenbe

OK, if there are no observable issues, it should be safe. I think you would get the same with a non-react vimeo embed.

goto-bus-stop avatar Nov 04 '21 07:11 goto-bus-stop