react-vimeo icon indicating copy to clipboard operation
react-vimeo copied to clipboard

Published 20 hours ago • verified publisher icon u-wave

Update oEmbed Attributes for Player

Open iuriandreazza opened this issue 3 years ago • 3 comments

Hey there, this is a simple addition to props to match the spec of the player.js embed options.

iuriandreazza avatar May 04 '21 12:05 iuriandreazza

@goto-bus-stop could you review this, if it's ok merge ? :) please let me know if you want to change in the PR

iuriandreazza avatar Jun 01 '21 17:06 iuriandreazza

I would love for this to be merged and released :pray:

jdpnielsen avatar Nov 30 '21 15:11 jdpnielsen

I guess we should add the props for this but as far as I can tell most of the player.setXYZ() methods this PR uses do not actually exist. They would have to use the appropriate methods instead, or not support changes at all if they can't be changed with the vimeo API.

goto-bus-stop avatar Dec 03 '21 10:12 goto-bus-stop

Sorry I left this for so long. the props this PR adds have been implemented in other changes in the mean time, so it's now obsolete I think. thanks for the contribution! 🥰

goto-bus-stop avatar Oct 17 '22 19:10 goto-bus-stop