gobusybox
gobusybox copied to clipboard
u-root
findpkg: if we drop support for Go 1.13, can this code be removed?
If we drop support for Go 1.13, can this code be removed?
There's a comment here I wrote a long time ago which refers to a section of code that only exists because of Go 1.13: Lines 172-205
However, this could still be useful because we emit these skip notes as part of the build.
If I remember correctly, when you look up a package that doesn't fit any build criteria through packages.Load on Go >=1.14, you'll get a similar error message. Maybe we can delete the code and emit a similar error message in those cases? I think this needs some experimentation.
(E.g. I don't think we want to turn those warnings into errors, which would happen if we just delete the code.)
To add to that, should we maybe bump the minimum Go version to something more recent like 1.16 instead of keeping 1.13 around or are there other reasons to still keep 1.13 as the minimum version?
I typically don't bump the minimum version until I find something that makes the tests fail before version 1.x or whatever.
I see a tangible reason here: 1.13 is old and we could gain some simplification (maybe). I'd bump to 1.14. But I don't see a reason to exclude 1.14 yet other than "it's older than 1.15".