WiFiManager icon indicating copy to clipboard operation
WiFiManager copied to clipboard

Only reconnect if WiFi updated

Open presslab-us opened this issue 2 years ago • 6 comments

If only the parameters have been updated then don't try to reconnect on save. Otherwise _ssid and _pass are blank (because "placeholder" input attribute is used) and the connection will fail.

presslab-us avatar Jan 27 '23 15:01 presslab-us

still a problem in the latest code

presslab-us avatar Oct 22 '23 16:10 presslab-us

What browser? placeholders should not be submitted in inputs

tablatronix avatar Oct 22 '23 17:10 tablatronix

Yes, exactly, the placeholder is not submitted, and therefore WiFiManager uses the returned (blank) SSID and password to reconnect. This causes the connection to fail.

My patch makes it so that if the SSID and password are not changed it will not try to reconnect with blank _ssid and _pass.

Tested with Chromium 110.0.5481.177

presslab-us avatar Oct 22 '23 17:10 presslab-us

If its blank then it shouldnt be connecting at all

tablatronix avatar Oct 24 '23 00:10 tablatronix

Is that the intended behavior? Every time that you go into the settings page you need to type in the ssid and password again, even if the placeholder is correct?

presslab-us avatar Oct 24 '23 00:10 presslab-us

No, I will take a look, something else seems to be broken also

tablatronix avatar Oct 24 '23 00:10 tablatronix