WiFiManager icon indicating copy to clipboard operation
WiFiManager copied to clipboard

Refactor strings BREAKING

Open tablatronix opened this issue 1 year ago • 2 comments

This is a possible breaking change if you have modified your strings file.

  • Constants have been moved to wm_consts_en.h
  • strings has been renamed to wm_strings_en.h, with shim left in
  • adds WM_STRINGS_FILE for env override of string asset
  • strings file MUST include a consts file as it contains localized tokens which are still used for web paths and error msgs and tokens

tablatronix avatar Aug 09 '22 23:08 tablatronix

Shit, I should not have moved the file in this commit, now you cannot see the diff!

tablatronix avatar Aug 09 '22 23:08 tablatronix

ok i cleaned up the pr to have a diff across branches forks for now

https://github.com/tzapu/WiFiManager/pull/1474/files#diff-fc99aa818cfc1d634b15c78450dfae31d4dabd8e76bb8436e4fa5a7a6392f24c

tablatronix avatar Aug 09 '22 23:08 tablatronix