tzapu
Update FS examples to use Arduinojson 6 (Fixes #1059)
Small direct updates to change the AutoConnectWithFSParameters and AutoConnectWithFSParametersAndCustomIP examples to make them compatible with Arduinojson 6
Fixes #1059
There is an open PR but it doesn't cover both example files (and seems to change a lot of unrelated code too...)
It seems to be fixed in hotfixes, not sure if I ever merged into master.
Either way it needs to be fixed in development branch also, not sure if I will be able to merge them without conflicts , ill check also
Let me look into the branches and see whats up, maybe that pr just missed some, ill try to clean them up today, thanks!
No worries! I left the development branch examples alone because it seems like they're not finalised yet
Yup it looks like I never made a release for the hotfixes changes, shoot.
Sorry about that, ill double check which one is better and merge them, thanks
I changed your target to hotfixes, here is the conflicts with what was already committed, I asked that that one be backward compatible, let me know if something is missing, we can probably just skip your PR, sorry to waste your time. I appreciate it.
https://github.com/tzapu/WiFiManager/pull/1060/conflicts
Yeah, that previous PR looks fine to me. The only thing is whether we use Static or Dynamic JSON documents, and what size they are, but ultimately this is example code so it's up to the end user.
Don’t worry Shawn, we’ll put money in your commissary account if you go to the GitHub slammer.
Don’t worry Shawn, we’ll put money in your commissary account if you go to the GitHub slammer.
Dont worry i know what Your doing and your going to jail