Tzanio Kolev comments

Results 901 comments of


                                            Tzanio Kolev

Update C++ standard to C++17 when building with Ginkgo

> So if we want to bump to 1.9, should I go ahead and clean up the checks for older versions? I could do it here (and edit the PR...

Update C++ standard to C++17 when building with Ginkgo

This looks good to me, thanks @nbeams. Can we get another approval from someone on the Ginkgo team?

Update C++ standard to C++17 when building with Ginkgo

> In general, I thought it looked like MFEM doesn't specify the minimum versions of dependencies in the CMake config, so I wasn't sure about adding it to Ginkgo. @tzanio...

Update C++ standard to C++17 when building with Ginkgo

Merged in `next` for testing...

Update C++ standard to C++17 when building with Ginkgo

@nbeams, can you merge `master` here and resolve the conflicts? Note that you also need to address [this change](https://github.com/mfem/mfem/pull/4723/files/b75b58faadd3b47c2d49c4bff9d4f37ce5266929#diff-0c53bce8f74b4f469712caf7ce78af7f020c9700387c4739732f8acf09517fd9) from [PR #4723](https://github.com/mfem/mfem/pull/4723) which got merged first. Thanks!

Update C++ standard to C++17 when building with Ginkgo

Thanks @nbeams !

Update C++ standard to C++17 when building with Ginkgo

Re-merged in `next` for testing...

Fix uninitialized variables in pmesh-fitting

Should I assume this is `ready-for-review`? 😁

Fix uninitialized variables in pmesh-fitting

This PR is now [under review](https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#pull-requests) (see the table in the PR description). To help with the review process, please **do not force push** to the branch.

Fix uninitialized variables in pmesh-fitting

Merged in `next` for testing...