Marin Atanasov

Results 25 comments of Marin Atanasov

> @tyxla, thank you for all your great feedback here! I think I've addressed everything. Let me know if you have the bandwidth to do a quick review of everything...

cc @flootr and @brookewp with whom we have been working on enzyme to testing-library migration in another repo recently 😉

@mirka thanks a bunch for your feedback 🙌 I've left a couple of questions on it and wanted to pick your brain and hear your thoughts, before I start addressing...

> I enjoy these discussions very much, thank you 😊 Me too, it's been particularly helpful and I appreciate you taking the time to go deep into that level of...

Indeed @swissspidy, we did uncover that later and refactored a few of the components from using `keyCode` to `code`, or `key`, however, it turned out that this broke stuff in...

Thanks for reporting this, @ryelle! Yeah, this was expected to happen, and it's a bummer that we have limited options to fix it. As you mentioned, a quick workaround for...

Here's a PR that should solve the problem: #43179. Once we merge it, we'll only need to publish new minor versions of the affected packages.

@gziolo I think this should resolve it: #43271. Do we have a clear case where we can test it to be sure?

@herndlm could you try altering the regex from `node_modules/(?!(is-plain-obj))` to `node_modules/(?:(?!is-plain-obj/).)*$`? and let me know if it works for you? See #43271 where I'm suggesting this. Also cc @acicovic.

Thanks for confirming so quickly, @herndlm!