e2fsprogs icon indicating copy to clipboard operation
e2fsprogs copied to clipboard

badblocks: fix operation with large block sizes and/or counts

Open bugfood opened this issue 3 years ago • 1 comments

Hi,

This PR fixes some issues I found when attempting to do a non-destructive read/write test on a hard drive. The default settings result in frequent seeking and overall low throughput, so my goal was to minimize seeking. Subject to memory constraints, reading/writing 2 GB at a time seemed reasonable, but I was unable to do so until making some changes.

Details are listed in each commit message.

Thanks, Corey

bugfood avatar Jan 24 '22 04:01 bugfood

@tytso is this PR acceptable? Please let me know if there is a procedure I need to follow; I wasn't able to find any guidelines beyond the SUBMITTING-PATCHES file in the repo.

bugfood avatar Jun 27 '22 04:06 bugfood

Applied, thanks.

tytso avatar Feb 01 '23 16:02 tytso

Applied, thanks.

Thank you.

-Corey

bugfood avatar Feb 01 '23 17:02 bugfood