Chris Tsang comments

Results 417 comments of


                                            Chris Tsang

Ident is not allowed to be empty; use Option<Ident> when generate entity

Thank you everyone ```sql REFERENCES apps # wont work REFERENCES apps(app_name) # works ``` So I can confirm that the culprit is the shorthand syntax of SQLite https://www.sqlite.org/foreignkeys.html Section 3...

Check to make sure migration name is valid

Hi @AngelOnFira welcome back!

Dynamic Table Name， a lot of tables with the same structure, it is not appropriate to define many structures with macros

Actually, it's possible to have an Entity that has a state, so your Entity is no longer a unit struct, but a `struct Entity(String)`.

Dynamic Table Name， a lot of tables with the same structure, it is not appropriate to define many structures with macros

Although I am not sure are there other blockers to this approach. But yeah at least it was designed that way, the `table_name` takes a `self`

Dynamic Table Name， a lot of tables with the same structure, it is not appropriate to define many structures with macros

Then probably a lazy_static with `Entity(&'static str)` would work

default_expr method not found in `sea_orm::ColumnDef`

I think sea-query now supports it, so it should be doable to add macro support in sea-orm

New Mapping options

Actually I don't quite understand the difference between embeddable and nested. For "Relationship", I think it's somewhat close to what `find_with_related` does now? I have a sense that the problem...

create_table_from_entity ignores max identifier length

Actually, I think we can leave it as is. It might be a good idea for the linter, though

Blanket IntoActiveValue implementations so custom db types are supported

I agree that we should support `Option` but what's the usecase for `Option` ?

Blanket IntoActiveValue implementations so custom db types are supported

Ah thank you for the context