pyfmodex icon indicating copy to clipboard operation
pyfmodex copied to clipboard

testing strategy

Open bbbart opened this issue 3 years ago • 7 comments

Proposal for testing:

We need to test for various platforms, various Python versions and various FMOD releases. I can set up something like tox to take care of some of it, but I think we'll also have to look into the CI infrastructure github is providing.

Proposal:

Python 3.7, 3.8 and 3.9
Windows, Mac OS and Posix
FMOD API 2.0 and 2.1

Possible simplification could be to only support (read: test) the latest release of the FMOD API.

One possible problem @tyrylu came up with is that it might be hard (or legally prohibited at least) to host libfmod libraries on the CI system.

What do you think?

bbbart avatar Mar 27 '21 16:03 bbbart

I agree with the testing matrix, so, if someone finds out a way how to get the library in place, we can likely setup something on GitHub actions quite easily.

tyrylu avatar Mar 27 '21 17:03 tyrylu

Let me see if I can reach someone over at FMOD for comment.

bbbart avatar Mar 27 '21 19:03 bbbart

I see that the Arch User Repository used to have the libraries available outside of the registered area of the FMOD website:

  • https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=libfmod
  • https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=fmodex

This hints that we might be allowed to do the same, although I'm not sure if that is the case of course.

Meanwhile, I sent the question on to two people at FMOD via personal messages on their qa-forum.

bbbart avatar Mar 27 '21 20:03 bbbart

Thank you. From cursory looks how the packages worked they used to download Fmod from a stable URL. If we could get something similar (and a silent Windows install), we could do something similar in the CI jobs.

tyrylu avatar Mar 28 '21 10:03 tyrylu

Got a reply on my private message on the forum with the simple suggestion of contacting their sales department. So I just sent them an email.

bbbart avatar Mar 30 '21 19:03 bbbart

good news:

Hi Bart

Thanks for writing. Great to see python bindings for FMOD.
Sounds like you would be covered under the EULA (fmod.com/legal) and wouldn’t need a special license if your project is non commercial.
You can ship the dynamic library files no problem with your project as this is how most free games operate anyway that use FMOD.

Let me know if I'm on the right track for your use case.

Regards,
Brett

so I guess we can move on here.

@tyrylu , do you have experience with Github actions/CI?

bbbart avatar Mar 31 '21 06:03 bbbart

Yes, i set up something similar for a Rust based project not long time ago.

tyrylu avatar Mar 31 '21 07:03 tyrylu