Kai Ren

Results 254 comments of Kai Ren

@JelteF @ilslv My first reaction to this was to remove `affix` functionality completely, just because it's so rare feature, that I've realized it exists just now, despite the fact I...

@ModProg > One helpful error could be when you specify a non default fmt string and neither specify `self` nor access `self` in any of the format arguments. Like telling...

@ModProg > But why wouldn't you use default in that case? > > ```rust > #[derive(Display)] > #[display(default("My app errored: {_0}"))] > enum MyError { > Io(io::Error, PathBuf), > Serde(serde_json::Error,...

@JelteF @ilslv @ErichDonGubler @ModProg First of all, I do like an idea of having `override` very much, but see this more an addition, rather than a requirement, and so, can...

@LegNeato this is definitely on my agenda in near future. However, the diif is huge enough, which will take some time.

@audunhalland I'm going to review this in next few days and [release in 0.17.0](https://github.com/graphql-rust/juniper/milestone/7).

@audunhalland > edit: also note for the review: I'm not sure I understand the `reflect` module fully, like e.g.: > > ``` > impl reflect::WrappedType for ArcStr { > const...

@LegNeato I'll look at this next week.

Same here. It would be nice to rollback to some specific day-version in case regression happens (like #12).

@sfackler would the contribution be appreciated? If yes, do you have any thoughts/ideas/plans about organizing this already?