Kai Ren

Results 254 comments of Kai Ren

@ilslv > Mainly how do we output errors of previous retries? Why not just output them as a regular error? > I expressed this concern before and I still think...

@ilslv also, it seems that we've missed how upstream implementation handles this. And it definitely should, according to [quick](https://github.com/cucumber/cucumber-js/blob/main/docs/retry.md) [googling](https://stackoverflow.com/a/65944590/1828012). Worth investigation, because complying with upstream is something that our...

@ilslv > Should we output only previous retry error or all of them? I think we should clearly output all the retry attempts and their results. > And I'm not...

@ilslv > By that I mean, that if we choose to go this route, retries can be outputted pretty far from each other, so maybe we should give users a...

@theredfish released in [0.14.0](https://crates.io/crates/cucumber/0.14.0).

@ilslv I'm not sure this is the responsibility of a `Runner`. It seems that a `Parser` may decide which `Features` should be fed first to the `Runner` (however, `Runner` still...

@ilslv yup, or even lower/higher `@priority`.

@Solonotix this library works the following way: 1. The whole execution pipeline consists of [`Parser` -> `Runner` -> `Writer`s](https://cucumber-rs.github.io/cucumber/current/architecture/index.html). 2. The parser of Gherkin files is abstracted in the way...

I guess we can close this now. Despite being [a controversial feature](https://github.com/cucumber-rs/cucumber/issues/106#issuecomment-948560104), it really feels like a responsibility of external tooling, rather than Cucumber itself. Feel free to reopen, if...

> It looks to me like the `install.sh` script might be incompatible with the latest tag of [cross](https://github.com/rust-embedded/cross) because specifying the previous tag works: It seems that default detection of...