hayagriva icon indicating copy to clipboard operation
hayagriva copied to clipboard

Fix unnecessary disambiguation around ibids

Open MaxGietl opened this issue 3 months ago • 3 comments

Fixes https://github.com/typst/hayagriva/issues/129.

Disambiguation currently compares the normal render of a citation. This means that if two different citations both render to "ibid", they are disambiguated without actually being ambiguous. This PR solves that by creating a second render that disables ibids and using that for comparison.

Example:

First mention of Smith @smith[1].
Second mention of Smith @smith[2].

First mention of Mayer @mayer[1].
Second mention of Mayer @mayer[2].

Hayagriva disambiguates the citations, even though they aren't ambigous. 

#bibliography("bibliography.yaml", style: "deutsche-sprache")

bibliography.yaml

smith:
  type: article
  title: First article of Smith
  author: Smith
  date: 1990

mayer:
  type: article
  title: Article of Mayer
  author: Mayer
  date: 2010

Faulty render without this PR Screenshot 2024-11-20 154755

Correct render with this PR image

MaxGietl avatar Nov 20 '24 14:11 MaxGietl