hayagriva icon indicating copy to clipboard operation
hayagriva copied to clipboard

Fix affixes with layout tag

Open skissue opened this issue 1 year ago • 2 comments

Fixes both prefixes and suffixes on the <layout> tag, which were not added before. I'm not sure if this is the correct way to implement this, I only took a cursory look through the code, but a quick test showed that it worked for the Chicago Manual of Style file.

Before:

Ungard-Sargon, Batya. “She Swoons to Conquer.” Edited by Pam Weintraub. Aeon (blog), September 25, 2015. https://aeon.co/essays/can-you-enjoy-romance-fiction-and-be-a-feminist

After:

Ungard-Sargon, Batya. “She Swoons to Conquer.” Edited by Pam Weintraub. Aeon (blog), September 25, 2015. https://aeon.co/essays/can-you-enjoy-romance-fiction-and-be-a-feminist.

Possibly addresses #107

skissue avatar Jun 04 '24 17:06 skissue

After some more experimentation, this PR (unsurprisingly) seems to break more than it fixes. Will take a deeper look at the code.

skissue avatar Jun 05 '24 13:06 skissue

I think the issue (of course, provisionarily) can be resolved when editing Chicago CSL, provided that suffix="." does appear in <group> within <layout> rather than in <layout> itself. https://github.com/typst/hayagriva/issues/107#issuecomment-2254537834

ironupiwada avatar Jul 28 '24 14:07 ironupiwada

With #273, affixes for bibliography entries are supported. I think citations should work too but I don't know of any failing cases in the first place. I'll be closing this then, but feel free to reopen if you find another case which needs a fix.

PgBiel avatar Apr 29 '25 22:04 PgBiel