asterank icon indicating copy to clipboard operation
asterank copied to clipboard

Close issue #19

Open nomad-vagabond opened this issue 7 years ago • 3 comments

resolve #19. Clicking on Sun button preserves lock on the selected asteroid and doesn't remove its orbit. Add 'Reset' button to deselect asteroid and reset view (can also be helpful to restore view from weird camera angles and scales). Earth selection behaviour is intentionally left unchanged as asteroid tracking can be a bit complicated from the Earth-locked view.

nomad-vagabond avatar Aug 11 '16 21:08 nomad-vagabond

Thanks Vadym for this excellent change :+1:

Could you help me understand the difference between clearLock and dropLock in the code?

typpo avatar Aug 19 '16 23:08 typpo

dropLock clears selection even if locked_object == null, while original method clearLock skip this action due to this line of code at the top: if (!locked_object) return. I implemented dropLock in order to force clearing selection from resetView method, which emulates absence of lock through declaration locked_object = null at the top. This declaration is needed to reset camera. A bit confusing - I know, but this is how I made it :) Please do not merge yet for I've just found a little bug in my ResetView method. I hope I'll fix it next week.

nomad-vagabond avatar Aug 20 '16 10:08 nomad-vagabond

Done!

nomad-vagabond avatar Aug 21 '16 18:08 nomad-vagabond