ad-detector icon indicating copy to clipboard operation
ad-detector copied to clipboard

Feature request: Safari version

Open m4p opened this issue 11 years ago • 5 comments

Are there plans to add a Safari Plugin as well?

m4p avatar Aug 16 '14 13:08 m4p

You can grab the Safari extension from my fork if you want to help me test it. It is pretty straight forward, but there seems do be an odd bug in effect that doesn’t always render the warning so I am not filing a pull request yet.

Screen shot comparing The New York Times with Forbes, the latter does not display the AdDetector alert.

Zegnat avatar Aug 17 '14 09:08 Zegnat

While appreciated, @Zegnat, your extension doesn't seem to work. The request for @typpo to integrate it should stay.

kleinmaetschke avatar Aug 18 '14 13:08 kleinmaetschke

Ditto. Can't find Safari extension to download, just an info.plist and icons. Sarafi extension would be GREAT! Thanks.

mnanda avatar Oct 19 '14 19:10 mnanda

Can’t find Safari extension to download, just an info.plist and icons.

My fork is very bare-bones, you will have to follow the instructions for running from source and then add the safari.safariextension folder through your extension builder.

But Ad-Detector has grown quiet a bit since I forked it so I should probably do a complete rebasing. I might have time freeing up again next week and if @typpo has not taken any steps towards Safari himself I can have another go at it then.

Zegnat avatar Oct 20 '14 12:10 Zegnat

Wow Martijin, thank you. I'm not a coder, just a girl who hates advertising. If you update it, I'll post about it in the comments on Lifehacker.com

Best regards.

Amanda

On Mon, Oct 20, 2014 at 5:01 AM, Martijn van der Ven < [email protected]> wrote:

Can’t find Safari extension to download, just an info.plist and icons.

My fork is very bare-bones, you will have to follow the instructions for running from source https://github.com/Zegnat/ad-detector#running-from-source and then add the safari.safariextension folder through your extension builder.

But Ad-Detector has grown quiet a bit since I forked it so I should probably do a complete rebasing. I might have time freeing up again next week and if @typpo https://github.com/typpo has not taken any steps towards Safari himself I can have another go at it then.

— Reply to this email directly or view it on GitHub https://github.com/typpo/ad-detector/issues/5#issuecomment-59736337.

mnanda avatar Oct 20 '14 16:10 mnanda